Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Onboarding: Add a URL history update when you pick a theme during the theme selection step #74910

Open dpasque opened 1 year ago

dpasque commented 1 year ago

Quick summary

During the onboarding flow, during theme selection at this URL: https://wordpress.com/setup/site-setup/designSetup?siteSlug=...

When you click on a theme to see its details, we don't push an update to the URL history, so you can't use the browser back navigation to go back to the theme selection. (If you do hit the browser back button, it will go all the way back to the prior step, which is usually site goal).

Since the theme preview is now an entire page view on its own now (instead of a modal), it feels weird to not have the URL history update!

Steps to reproduce

  1. Start a new site (wordpress.com/start)
  2. Get the theme selection step: https://wordpress.com/setup/site-setup/designSetup?siteSlug=
  3. Click on a theme -- note that the URL doesn't change, and you can't use the browser back button to go back to the theme selection.

What you expected to happen

There's a URL history entry, and browser back button takes me back to the theme selection page.

What actually happened

No URL history update, back button goes back to the prior step.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

No response

cuemarie commented 1 year ago

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

📌 FINDINGS/SCREENSHOTS/VIDEO

https://user-images.githubusercontent.com/27249804/228697232-bf49e33b-3ec1-491b-9b4e-a7b3181386ac.mov

📌 ACTIONS