Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.4k stars 1.98k forks source link

Upgrade banner dismissal hidden in Calypso #75854

Open ebinnion opened 1 year ago

ebinnion commented 1 year ago

Quick summary

After removing the domain credit for one of my sites I noticed this upgrade banner that didn't have a dismissal "X" button. After loading the wp-admin for my Atomic site, I did get a banner that had the dismissal "X".

Screenshot 2023-04-14 at 10 44 57 PM

Steps to reproduce

  1. Purchase Atomic site.
  2. Remove domain credit in store admin.
  3. Go to /stats/$site_slug and notice the missing "X"

What you expected to happen

For the banner to not appear misaligned.

What actually happened

Misaligned banner due to hidden button.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

cuemarie commented 1 year ago

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

📌 FINDINGS/SCREENSHOTS/VIDEO

Screenshots/Recordings

It's actually there and works as a dismiss button, but it's invisible:

Markup on 2023-04-19 at 17:02:36


By comparison, wp-admin pages show the cross as expected:

Markup on 2023-04-19 at 17:06:29

📌 ACTIONS