Post Carousel appears empty when displaying posts with no featured image set

edwinho89 commented 1 year ago

Quick summary

Post Carousel block stopped working, not displaying posts.

On the editor, the Post Carousel block loads fine.

Steps to reproduce

Create a new page
Insert Post Carousel Block
Publish and view page

What you expected to happen

Post Carousel block loads as normal

What actually happened

Post Carousel block is not loading anything on site.

Impact

Most (> 50%)

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

Gutenberg: v15.6.0 Editing Toolkit: 3.62949 WP AMP: 2.0.5 CoBlocks: 2.18.1-simple-rev.3

edwinho89 commented 1 year ago

42749051-hc

edwinho89 commented 1 year ago

It now seems to work if the Post Carousel block contains posts with featured images.

Can still reproduce the above when posts do not have featured images.

cuemarie commented 1 year ago

Looks like this has been escalated a couple places:

p1681965649141259-slack-CBTN58FTJ
p1681969428792429-slack-C02FMH4G8

@liviopv asked within the thread p1681980701470919/1681969428.792429-slack-C02FMH4G8:

Is the block supposed to work without Featured Images?

But that's been a little buried by some higher priority escalated issues following the release of Gutenberg 15.6.

Seems like we should find that out next. I'll also test if the block behaved this way before 15.6 (I have a sense it did, and this is not specifically tied to that release - but I'll know more a little later!)

cuemarie commented 1 year ago

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

Tested on Simple – Replicated
Tested on Atomic – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO

Replicated across a few different environments. On the front end, the Post Carousel block matches the image in the original report when it contains only posts missing featured images in Gut 15.6.1, 15.5.1, and with Gutenberg disabled.
In the editor, the Post Carousel Block can be seen with it's missing images on a refresh, but when you have a Post Carousel block containing feature images and then remove those, the block is rendered invisible in the editor altogether.

Possibly a symptom/regression of https://github.com/Automattic/newspack-blocks/issues/542 ?

Screenshots/Recordings

Editor Experience

https://user-images.githubusercontent.com/27249804/233498104-cbbb2706-0840-408d-93e3-b3636f8eac5c.mp4

Other Notes

This bug: https://github.com/Automattic/wp-calypso/issues/73069 exhibits the same symptom, but is triggered when a classic block sets pages to not display featured images, impacting this block as well.

📌 ACTIONS

Assigned to Apex

cuemarie commented 1 year ago

I still think some understanding of what should happen is needed. Here's a very similar report, where HE's/Users expected that posts missing featured images would not be shown at all: https://github.com/Automattic/wp-calypso/issues/55258