Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.4k stars 1.98k forks source link

Site Editor: Replace Template Part option missing from List View Options if block not selected #77280

Closed csabarakasz closed 2 weeks ago

csabarakasz commented 1 year ago

Quick summary

When I want to replace a Header Template Part in the Site Editor, the replace header option only shows up in the floating menu, not in the List View.

Steps to reproduce

  1. Click List View > three dots next to Header:

dgw2X8UnU3buRZtK7Zw8emcxewpY09CiJWtpPY0X.jpg

  1. Click List View > Select the Header > click the three dots from the floating menu > Replace Header options is there:

M6vdHm30kgHT6iIEUa4RV8SKpPMzFTincSXLmi72.jpg

If I remember correctly, it used to be there at both places.

What you expected to happen

The option would show up at both block setting menu.

What actually happened

Only show up on the floating menu.

Impact

All

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

In Gutenberg 15.8 the Block Settings menu was rearranged. I wonder if it is connected

csabarakasz commented 1 year ago

Sharing again to link the two GitHub links. I wonder if this is related: https://github.com/WordPress/gutenberg/pull/50453

csabarakasz commented 1 year ago

Ps.: there are also two Edit buttons in the floating menu πŸ€·β€β™‚οΈ πŸ˜†

cuemarie commented 1 year ago

πŸ“Œ SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

πŸ“Œ FINDINGS/SCREENSHOTS/VIDEO

Screenshots/Recordings

https://github.com/Automattic/wp-calypso/assets/27249804/3c39d8db-df82-41ca-9954-28819781bff9

Test Sites:

Atomic Site

Simple (Edge) Site

Outside of DotCom

πŸ“Œ ACTIONS

cuemarie commented 1 year ago

Ps.: there are also two Edit buttons in the floating menu πŸ€·β€β™‚οΈ πŸ˜†

@csabarakasz as this is a different issue, it should be reported separately rather than in the comments here. I've created this report:

cuemarie commented 1 year ago

This comment provides some good insight into the underlying issue here. This issue may remain for the time being, as it's a bit more complicated and less impactful than other issues in the works at the moment.

annezazu commented 2 weeks ago

I can't replicate this using WP 6.6.1 and GB 19.0:

https://github.com/user-attachments/assets/e882da78-0bd0-47dd-b5ee-31e7d3bfab60

I'm also not seeing any recent reports here. Happy to reopen and have folks investigate if we can get more up to date steps.