Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.4k stars 1.98k forks source link

Themes: Remote, Upsidedown, George Lois, Archivo - with Gutenberg plugin, editor content does not follow max width #78473

Open sophiegyo opened 1 year ago

sophiegyo commented 1 year ago

Quick summary

Several a8c themes whose content in the editor view should have constrained width to match the live view, are currently not showing constrained width when the Gutenberg plugin is active.

Replicated on:

Themes where this issue occurs so far:

Additional themes tested where I could not replicate this issue:

Steps to reproduce

  1. Start at any WordPress site with Gutenberg 16.0.0 active
  2. Ensure one of the following a8c themes is installed:
    • Upsidedown
    • George Lois
    • Remote
    • Archivo
  3. Edit an existing page

What you expected to happen

The content within the editor should have margins to the left and right which somewhat match the live view.

Example taken from how Upsidedown looks in the editor WITHOUT Gutenberg:

image

Live view:

image

What actually happened

The editor view of the content isn't as 'centered':

image

Live view remains as normal.

IMO this is happening because something in these themes is being overriden by Gutenberg to prevent editor-styles max-width or margin being set. No space here:

image

Margin AND max-width here:

image

This seems to follow on the themes I've mentioned so far; I'm not sure if there are others.

Impact

Some (< 50%)

Available workarounds?

Yes, difficult to implement

Platform (Simple and/or Atomic)

No response

Logs or notes

Tested with: WP 6.2.2 Gutenberg 16.0.0

I put the workaround as 'yes, difficult to implement' because on dotcom the workaround would be 'Deactivate Gutenberg' which isn't really viable for Simple sites.

It isn't a usability issue, more of an aesthetic issue - but we've had a couple of complaints. See p7DVsv-hGe#comment-46328-p2

liviopv commented 1 year ago

Reproduced using George Louis on a local site:

CleanShot 2023-06-21 at 12 02 20

cuemarie commented 1 year ago

Noting this was escalated here: p1687345113536249-slack-C02FMH4G8

cuemarie commented 1 year ago

πŸ“Œ SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

πŸ“Œ FINDINGS/SCREENSHOTS/VIDEO

Screenshots/Recordings

Simple Site

Markup on 2023-06-21 at 13:41:05

Atomic Site - Comparing Gutenberg Versions

https://github.com/Automattic/wp-calypso/assets/27249804/6ccf9d4f-4253-4c60-b349-0ba883e15d9c

πŸ“Œ ACTIONS

autumnfjeld commented 1 year ago

We are working on getting this fixed. Both on fixing issues in the themes and addressing a GB bug p1687398032551969/1687345113.536249-slack-C02FMH4G8

Robertght commented 1 year ago

Reporting another case with Adventurer 6421098-zd-woothemes

github-actions[bot] commented 1 year ago

Support References

This comment is automatically generated. Please do not edit it.

cuemarie commented 1 year ago

Also reported and repro'ed on theme Adventurer. Interaction from #78516 :

cuemarie commented 1 year ago

πŸ“Œ ACTIONS