JITM 'dismiss' cross icon not showing up.

[PZ01]

I implemented a dismissable JITM in the jitm-engine class. Upon viewing it, I did not see any 'X' mark. I inspected the element and did see a cross-hair icon label in the HTML. I suspect something is wrong with the resource URL path.

I was on a private browsing session.

[jeherve]

I'll move this issue to the Calypso repo, since this specific JITM was built in Calypso: https://github.com/Automattic/wp-calypso/tree/233ac1ad7ed0a8638b095a5aaa9f61f11227ebf7/client/blocks/jitm

[dpasque]

Reproduced: Something is off with the styling for these JITM sidebar banners in Calypso. This only affects dismissable ones (like certain upsells and domain sale notifications). This also is unique to Calypso styles -- if you view in wp-admin the styling is just fine!

Also worth noting: it's still a button and you can click on it to dismiss it!

I'm going to start this at High priority... This affects basically everyone, and I could see some people getting mad that they can't dismiss these.

[dpasque]

Sending to MarTech as this is upsell/JITM related.

[PZ01]

Reproduced: Something is off with the styling for these JITM sidebar banners in Calypso. This only affects dismissable ones (like certain upsells and domain sale notifications). This also is unique to Calypso styles -- if you view in wp-admin the styling is just fine!

Also worth noting: it's still a button and you can click on it to dismiss it!

I'm going to start this at High priority... This affects basically everyone, and I could see some people getting mad that they can't dismiss these.

Thanks Dan, and yes indeed someone did get mad before I made it dismissable, which remains case in point that when these are hitting paying customers and they can't remove them, it causes friction. p1689120996954219/1689120912.481419-slack-C029GN3KD

[cuemarie]

📌 ACTIONS

• Closed as resolved thanks to https://github.com/Automattic/growth-foundations/issues/126
• FYI @PZ01 in case I'm wrong about that, please feel free to reopen 👍

[PZ01]

👋 That issue had to do with email campaign promotion fixes that were solely on the back-end.

I just pulled the latest calypso and the icon remains problematic:

[cuemarie]

@PZ01 Got it - thank you for clearing up my understanding!

[cuemarie]

📌 ACTIONS

• After reviewing the timeline on this issue, I've downgraded the priority from High to Normal to better reflect its status in the larger context of open bugs in this repo.

[katinthehatsite]

It seems that the issue is resolved for now - testing on my end now, I can see the X visible on the notices where it is added:

On some notices, the button is not present at all but it looks like this is done by design:

I see that some notices do not have is-dismissable prop so they don't have the cross to remove them. The ones that have the prop, display the cross correctly:

Since it can't be reproduced anymore, I will close this issue. Feel free to re-open if the issue happens again!