search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Stats: link to subscribers stats remains when Subscriptions module is disabled #80572

Open jeherve opened 1 year ago

jeherve commented 1 year ago

Quick summary

Jetpack allows you to disable the Subscriptions feature on your site. Odyssey stats include a "Subscribers" tab linking to subscriber stats. This tab probably should not be displayed when the module is disabled.

Steps to reproduce

Start with Jetpack site connected to WordPress.com.

  1. Go to wp-admin > Jetpack > Settings
  2. Disable the Subscriptions feature
  3. Go to wp-admin > Jetpack > Stats

What you expected to happen

I expected to see info about my stats, and no mention of "subscribers"

What actually happened

A "Subscribers" tab is displayed:

image

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Atomic, Self-hosted

Logs or notes

No response

kangzj commented 11 months ago

@Automattic/apex Hey folks, I'm not sure which team is working on the launchpad project. Should we leverage the opportunity here too? Or it is already applied here?

yansern commented 11 months ago

@Automattic/apex Hey folks, I'm not sure which team is working on the launchpad project. Should we leverage the opportunity here too? Or it is already applied here?

Off-topic: Conversation continued in p1702461277152309-slack-C82FZ5T4G. In short, we need to check if Launchpad APIs are accessible from Jetpack end. (Not entirely related to the issue above.)

kangzj commented 3 months ago

Hi @simison, I got a question for you - what happens if the Newsletter module is turned off but the site still has a bunch of subscribers, do we want to hide the Subscriber page? Or we show it all the time? There're proper launch pad actions when there's no subscribers atm. Thanks.

image
simison commented 3 months ago

@crisbusquets thoughts on above?

I'd still lean towards hiding; what's left in subscriptions DB is more like leftovers if they're closing the newsletter.

It'll be important we allow store them, manage them and export. Historical stats gives me a bit of a pause, and makes me think we should keep UI visible.

crisbusquets commented 3 months ago

Historical stats gives me a bit of a pause, and makes me think we should keep UI visible.

What do you think about keeping them as historical, and also add a small alert to remind them that the feature is disabled? As a nudge to reactivate.