Intermittent: Customizer CSS is missing after site goes Atomic

Automattic / wp-calypso

The JavaScript and API powered WordPress.com

https://developer.wordpress.com

GNU General Public License v2.0

12.4k stars 1.98k forks source link

Intermittent: Customizer CSS is missing after site goes Atomic #81593

Open metabreakr opened 1 year ago

metabreakr commented 1 year ago

Quick summary

Similar to #76642 — when a simple site is built and CSS is added through the Customizer, that CSS is lost when a site goes Atomic — the Customizer's Additional CSS field is blank, similar to when one theme is switched for another.

Steps to reproduce

Activate a Varia theme (e.g. Shawburn) on a simple site
Add some custom CSS to the Customizer
Push the site to Atomic
Open the Customizer again, and observe that the CSS is missing

What you expected to happen

I expected the CSS to remain in the Customizer after the site goes Atomic.

What actually happened

Any CSS added in the Customizer is removed, and needs to be added again.

Impact

Most (> 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Atomic

Logs or notes

This most recently occurred when building pdEkSe-4WM-p2

cuemarie commented 1 year ago

📌 REPRODUCTION RESULTS

Tested on TT3 – Could Not Replicate
Tested on Varia – Could Not Replicate

📌 FINDINGS/SCREENSHOTS/VIDEO

I was not able to reproduce this issue on Varia or TT3 🤔

Varia:

https://github.com/Automattic/wp-calypso/assets/27249804/a693a1af-a3d9-4863-a920-1ba7eb443208

TT3:

https://github.com/Automattic/wp-calypso/assets/27249804/c0701eef-3eed-4883-ac07-c76cc51e4bb3

Will try again with some child themes and report back...

metabreakr commented 1 year ago

@cuemarie Hmm. I will try and replicate this again in the same way that I built the site in the P2 (not that it's anything out of the ordinary)

metabreakr commented 1 year ago

I couldn't reproduce this again, so will close this issue for now until it happens again.

ccwalburn commented 11 months ago

Reopening this issue as this has happened again. 7093294-zd-a8c User was using the Morden theme on a Premium plan and did not change themes after upgrading and going AT.

github-actions[bot] commented 11 months ago

Support References

This comment is automatically generated. Please do not edit it.

[ ] 7093294-zen

cuemarie commented 11 months ago

THanks @ccwalburn - I just ran a site using Morden through 2 tests and still wasn't able to repro:

Test 1: Simple Business Site -> Atomic Business site (transferred to AT via plugin install) Recording
Test 2: Simple Premium Site -> Atomic Business site (upgraded and transferred to AT via plugin install) Recording

📌 ACTIONS

I'll leave this open to see if anyone else runs into it.

📌 Message to Future HEs

Transferring AT alone does not seem to explain this behavior - if you run into users who report this, try to get as much information as you can about the steps they took to upgrade, when the CSS was originally added to their site, etc, so that we can try to identify any patterns. Thank you!

metabreakr commented 11 months ago

@cuemarie Could this be related to #82363 ?

cuemarie commented 11 months ago

Could this be related to https://github.com/Automattic/wp-calypso/issues/82363 ?

It certainly seems like a similar issue - intermittently losing theme customizations (whether that's via CSS, global styles, or templates) when sites go AT. It's tough to find a pattern tho as we haven't been able to reproduce either one consistently, though, so for now we'll need to keep both open and see if we can find a pattern if/when more reports come in.