Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.4k stars 1.98k forks source link

Plans Grid: glitches in sticky action buttons when scrolling #82853

Open jsnajdr opened 11 months ago

jsnajdr commented 11 months ago

Looking at the plans grid (at wordpress.com/plans/example.com) I noticed several glitches related to the "Upgrade" action buttons. They are all visible in the screencast that's attached below.

  1. The font size on the buttons changes when they become sticky. (All except the Downgrade button.) There is no reason for that, they continue to be exactly the same buttons. I understand why the labels change to include the price, that's because the price info has scrolled away, but I think no other changes are justified.
  2. I was confused by the "Upgrade – €17" label. At first I read it as "minus €17", as a discount (and there actually is a discount there!), and only later I realized it's a "dash followed by the actual price". I think "Upgrade (€17)" would be a better label, ruling out the "minus" interpretation.
  3. When I scroll up, then on the bottom edge of the page the action buttons also become sticky (or at least get the sticky styling), but they are not really sticky, they scroll away.

https://github.com/Automattic/wp-calypso/assets/664258/c4533379-256c-4e0e-b4d7-1ffe6f1ae0e3

cuemarie commented 11 months ago

📌 REPRODUCTION RESULTS

📌 FINDINGS/SCREENSHOTS/VIDEO Replicated the font size change and

Font Size Change

DN94Yy.gif

Button change at bottom of viewport

sZVj6L.gif

📌 ACTIONS