Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Admin Notice Prompting Jetpack Install Even Though It's Already Active #83874

Open katiebethbrown opened 1 year ago

katiebethbrown commented 1 year ago

Quick summary

We're seeing an admin notice prompting for Jetpack to be installed, even though it's already installed and active on the site:

CleanShot 2023-11-03 at 10 17 48@2x

We're running a child theme of Dara. Dara appears to be prompting for Jetpack install for feature dependencies, via pluginenhancements.php.

I think this is happening because we're pulling a list of plugin names into an array, and then looking for the name Jetpack by WordPress.com. But I think the plugin is just named Jetpack now, so there’s not match detected and the error shows.

Related Slack Discussion: p1698949619753949-slack-C029FM1EH

cuemarie commented 1 year ago

📌 REPRODUCTION RESULTS

📌 FINDINGS/SCREENSHOTS/VIDEO I am able to replicate this, but only with the non-wpcom version of the theme, v1.2.1, available in the WordPress.org themes catalog: https://wordpress.org/themes/dara/

WordPress.com Atomic site

Markup on 2023-11-06 at 11:25:08

Self-Hosted (Pressable) site

Markup on 2023-11-06 at 11:19:39

📌 ACTIONS

dsas commented 1 week ago

Looks like the difference isn't because of the versions, but because we don't add the plugin-enhancements.php file for wpcom, it's added for wporg by the org-submitter

The fix would be to change the org-submitter, then regenerate all of the relevant theme zips so the new plugin-enhancements.php gets bundled with it.