Closed donnapep closed 8 months ago
Hi @yscik and @gkaragia! 👋 I'd like to ping you here, just in case you remember something important about this or links with references for us to avoid re-creating a bug or something like that.
Hey @renatho! So I remember that we initially started considering removing WC installation from the flow because we were trying to solve a Jetpack Identity Crisis issue and I believed that it had to do with timing so making our flow faster would stop the issue from happening.
However, there were also some other issues IIRC. It seems that we had a discussion about it (p1677600664777249-slack-C048ZJB2QNM) but I can't find it unfortunately. So the issues that we were having when we also installed WC as part of the onboarding flow were the following:
So for the two reasons above together together with the possibility of solving the JIC we ended up removing Woo. Also, there is an upsell to install Woo already in wp-admin so we thought that users that want to install it, can use this menu anyway. The JIC were not affected at all from WC so you shouldn't worry about introducing this bug if you re-add it. Also, the JIC issues should be solved (or are more unlikely to happen) after a fix that added some delay in the atomic transfer. And the Woo flow might be more streamlined now or easier to configure.
So if you want to implement this, you should install WC as a first step (this should be easy to achieve by adding the plugin slug somewhere in the code IIRC) and test the user experience once the user is redirected to home. Hope that helps!
It's definitely helpful! Thank you @gkaragia!
Just adding here a reference to the JIC to connect the points: https://github.com/Automattic/wp-calypso/pull/74004#pullrequestreview-1324045455. I thought it could be related to https://github.com/Automattic/wp-calypso/issues/84350, but it seems something completely different.
Issue created for the implementation: https://github.com/Automattic/wp-calypso/issues/85857
Details
In Sensei LMS's onboarding wizard, WooCommerce is installed / activated when "Sell courses and generate income" is selected on the Purpose step:
However, this same behaviour is not present on Atomic sites. From what I've gathered by reviewing P2s and PRs, it seems like we originally added this functionality, then subsequently removed it, possibly because of this issue.
Checklist
Related
No response