JanaganSaravanan
commented
10 months ago Hi! I would like to work on this issue. Can you assign this ? And give me some head start if possible. Thank you,
Open southp opened 10 months ago
JanaganSaravanan
commented
10 months ago Hi! I would like to work on this issue. Can you assign this ? And give me some head start if possible. Thank you,
maciejpilarski
commented
10 months ago The issue I worked on - 1. The same add-on cannot be repurchased from /add-ons after cancelling.
📌 REPRODUCTION RESULTS – Tested on Atomic – Replicated
📌 FINDINGS/SCREENSHOTS/VIDEO I was able to create the issue on my test site premiumplantest2.wordpress.com, after the canceling the 50GB upgrade, I am unable to repurchase it, I can only buy the other option that was never purchased 100GB
📌 ACTIONS – Triaged
📌 Message to Author Hi @southp!
Thanks for your detailed reports. I appreciate your effort, but would also ask to file all the issues as separate bugs, not a combo bug with 6 issues listed. This way it's easier for us and the dev to triage and work on the issues.
I have worked on your first issue and was able to reproduce it. Are you able to modify your report and file the remaining five reports separately?
Thanks in advance!
southp
commented
9 months ago @maciejpilarski Thanks for the suggestion. You are right that I should have broken it down into separate issues from the first place. It's now broken down accordingly:
Since you mentioned that you are working on the 1st issue, I've also assigned that to you :)
southp
commented
9 months ago Hey @JanaganSaravanan , thanks for pitching in.
Hi! I would like to work on this issue. Can you assign this ? And give me some head start if possible. Thank you,
Now that it has been broken down granular, you can feel free to grab one that interests you the most. We can then move on our conversation there, including the head start pointers. Does that work for you?
JanaganSaravanan
commented
9 months ago Yes! Absolutely. Thank you,
dzver
commented
9 months ago Adding one thing here
The dropdown is only available on Annual plans. It should be available for 2 and 3-year plans, assuming the monthly option doesn't make sense.
CC @southp for confirmation
southp
commented
9 months ago Good quesiton, @dzver . I raised the same question when this project first started, but the decision was that the storage add-on would only have the annual term in this phase. Back then it was not obvious, but it's now revealed by the term dropdown.
@gmovr Do we have 2-year and 3-year products for the storage add-ons?
If not, I think it'd still be better to enable the storage drop-down for 2-year & 3-year plans, which will add the annual storage add-on subscription to their cart. We'd just need to be cautious on how it is communicated on the UI. Does that make sense?
dzver
commented
9 months ago We don't have 2 and 3-year storage add-ons and we don't plan adding such. Despite that, the upgrade can still be purchased from the add-ons page.
It looks like a bug right now but not a high-priority one.
southp
commented
9 months ago Cool. I've created a tracking issue here: Automattic/martech#2614.
ddc22
commented
9 months ago It looks like a bug right now but not a high-priority one.
@dzver I think this was deliberately hidden due to the lack of calrity in the requirement at time of development (CC - @jeyip) Just want to ping all of you unless there is some other reason we should NOT be doing this (Show add ons in all multi year plans) :)
Working on this @ https://github.com/Automattic/wp-calypso/pull/86807
ddc22
commented
9 months ago @dzver I did some exploration and had some feedback from @jeyip . First I want to clarify and understand what exactly you're suggestion is... I can guess two approaches that might be on your mind.
If you meant this approach, then we have some UI complexity involved on the plans grid. Because the Primary price displays a "monthly" price as well as a "Relevant term renewing price". For example if its a 3 year plan we show a calculated monthly price as well as the price to be paid at the end of 3 years.
We will have to do some frontend calculations to come up with the equivalent monthly and relevant term renewing price for storage add-on. But even then there is a chance for confusion, since even though we say that it costs a given amount at the end of a given term, the storage add on will always require payment annually. This is misleading given that the drop down says "Pay every 3 years".
Checkout however shows a better view of this context which I am not sure if we can replicate in the plans grid.
This would make things much more simpler. But I am not sure of the possiblity of doing this since this was not attempted in the first place.
PR available to explore and play around with this options enabled https://github.com/Automattic/wp-calypso/pull/86807
The calculations are currently incorrect, but the checkout works well.
CC - @gmovr @vinimotaa @saygunnyc @isatuncman-auto @jeyip
dzver
commented
9 months ago If the calculations are difficult to implement, I'd rather abandon the task than complete it. This is only worth fixing if it's easy.
ddc22
commented
9 months ago Abandoning PR for now due to complexity and low priority of task.
jeyip
commented
8 months ago
- The drop-down state is shared between sites.
Addressing this low-hanging fruit in https://github.com/Automattic/wp-calypso/pull/87342
1. The same add-on cannot be repurchased from
/add-onsafter cancelling.https://github.com/Automattic/wp-calypso/assets/1842898/0751018a-5f87-4dd2-bd20-906e341ee2f0
From a quick glance, using transaction history to determine whether one has owned an active storage add-on is wrong. This issue will also cause other anomalies in /plans, but I didn't include them here since the root cause is the same. This might potentially relate to Automattic/martech#2418.
2. A user can't buy the 50G add-on and then buy the 100G add-on
As shown here, my test Business site owning a 50G add-on can't buy the 100G add-on since it's absent. In /plans, it's even more confusing since I can select it but it will show me "Contact Support"
It should be available since the maximum storage is 200G. From a quick glance of the code, the way
exceedsSiteStorageLimitscomputed is wrong.3. The confusing "Contact Support" button when owning a storage add-on.
When owning a storage add-on, picking a lower-tier storage in /plans will show "Contact support":
it also applies to a higher-tier plan:
This relates to Automattic/martech#1458. However, even with the Downgrade button, it won't be less confusing. My recommendation is to simply hide the lower-tier storage options in
/plans, which is not the best place to downgrade anyway.4. Inconsistent price combining of the spotlight plan card
https://github.com/Automattic/wp-calypso/assets/1842898/7519a65b-c25d-4105-992d-9fc67760bbee
As demonstrated above, when we first select a storage add-on before owning one, it shows the combined price in the spotlight plan card. After that, it turns into just the plan price with some flickering between texts.
I'm not sure what's the best behavior here. It's confusing to me to show the combined price, since there is a "+X / month" under the dropdown. I'd prefer us to show them separately, sort of like the final state in the screencast. However, that doesn't align with how the other places in /plans work.
@vinimotaa Could you share your insights here? I'd be grateful.
5. Runtime error by typing certain keystrokes
See https://github.com/Automattic/wp-calypso/issues/82546
6. The drop-down state is shared between sites.
https://github.com/Automattic/wp-calypso/assets/1842898/29078107-dd09-486e-8cca-d9a5bb8537b5
As demonstrated above, the drop-down state stays after changing sites. This might be fine, but I'm still documenting it here in case it actually causes other issues.