Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Coupon discount is wrong in checkout for multi-year domains #86551

Closed sirbrillig closed 9 months ago

sirbrillig commented 10 months ago

The coupon discount amount shown by checkout does not include product volume and therefore is incorrect for multi-year domains. In addition, since this number is currently being used to calculate the "Subtotal" being displayed in checkout, that number is also wrong.

Screenshot 2024-01-17 at 10 47 19 AM

This has been broken for a very long time. Probably ever since we started showing a coupon discount amount. We never noticed because very few products have used volume until multi-year domains.

To reproduce:

sirbrillig commented 10 months ago

Will be fixed by D134952-code. I'll see if I can fix it sooner.

Here's how it should look:

correct-coupon-discount