search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Scheduled Updates: Add Plugins menu item with drilldown #90577

Closed obenland closed 5 months ago

obenland commented 6 months ago

This will add a "Plugins" menu item to the new multisite UI with a drilldown function to expose submenu items. We don't want to expose the multisite plugins page at this point, so the only submenu item should be "Scheduled Updates".

Let's make sure we stay closely aligned with @davemart-in, @lucasmendes-design, and @JanaMW27 on this one.

See video mockup in p9Jlb4-bDg-p2#comment-11238

github-actions[bot] commented 6 months ago

Support References

This comment is automatically generated. Please do not edit it.

lucasmendes-design commented 6 months ago

Nice to hear that 🚀

I have a question. Are we using the same data table (A4A - JetPack) as the one on the site list? Let's make sure that we won't add one more data table UI.

Please ping me whenever you need me, I'm happy to help :)

davemart-in commented 6 months ago

This will add a "Plugins" menu item to the new multisite UI with a drilldown function to expose submenu items. We don't want to expose the multisite plugins page at this point, so the only submenu item should be "Scheduled Updates".

Just wanted to double check that the submenu item doesn't live on the global nav itself, but shows only after you click into "Plugins".

bogiii commented 6 months ago

Just wanted to double check that the submenu item doesn't live on the global nav itself, but shows only after you click into "Plugins".

Exactly, that's the idea.

Are we using the same data table (A4A - JetPack) as the one on the site list? Let's make sure that we won't add one more data table UI.

Are you talking about the sites table, which lives on the /sites route? If so, it's not implemented in a way that can be easily reused. The scheduled updates list is already implemented, and it can be found here: wordpress.com/plugins/scheduled-updates.

In other efforts, we could create a reusable data table component in a unified, maintainable place and apply it to the existing features (sites, scheduled updates, etc.).

lucasmendes-design commented 6 months ago

In other efforts, we could create a reusable data table component in a unified, maintainable place and apply it to the existing features (sites, scheduled updates, etc.).

How far are we from this? In my mind, I thought we had the data table component that could be reused =/

davemart-in commented 6 months ago

@cleacos just tagging you on this convo. Figured you might be able to share some context on the current state of things with regards to reusing the data table for things outside of sites.

cleacos commented 6 months ago

If I understood correctly, you want to create a new Plugins section and reuse the data table component with the Preview Pane option for any expanded option. It's possible with the current implementation; just use the ItemsDataViews component; it's agnostic about the context. I'd be the same process, it will need a wrapper component, PluginsDataViews and if you want the Preview Pane, another wrapper component, PluginPreviewPane and these components grouped by a new one called PluginsDashboard: