Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Classic Themes: Jetpack Likes and Sharing conflict with Dotcom Sharing Buttons settings #91371

Closed mxhassani closed 5 months ago

mxhassani commented 5 months ago

Quick summary

When Marketing > Sharing Buttons > Front Page, Archive Pages, and Search Results is ON, and the Homepage has Likes and Sharing > Show likes OFF, a perpetual Loading.. element becomes visible on the homepage.

Classic Themes on Simple sites only.

Steps to reproduce

  1. Create a simple site
  2. Enable a classic theme on it (i.e Canape)
  3. Make sure Marketing > Sharing Buttons > Front Page, Archive Pages, and Search Results is checked.
  4. Set a static page as the homepage, under Appearance → Customize → Homepage Settings → A static page → Homepage
  5. Go to your pages list and edit the page you've set as the homepage in 4.
  6. On the top right part of Gutenberg, click the Jetpack icon.
  7. Make sure Likes and Sharing > Show likes is OFF.
  8. Visit the front end of the site (homepage).
  9. Notice the loading.. text just before the footer

What you expected to happen

To not see the "Loading" mention

What actually happened

I see the following "Loading" mention: image

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Simple

Logs or notes

Workaround

Make sure Marketing > Sharing Buttons > Front Page, Archive Pages, and Search Results is unchecked.

Or, use CSS:

.home #jp-post-flair{
  display: none;
}
rickmgithub commented 5 months ago

📌 REPRODUCTION RESULTS

📌 ACTIONS

Triaged

Message to author

Thanks so much for the report @mxhassani I couldn't replicate the issue with the same set up? Are you still able to produce this on a number of sites? Feel free to reopen if you can still replicate.