Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.39k stars 1.98k forks source link

Additional CSS option is unavailable on FSE themes on Starter Plans with Custom CSS subscription #92014

Open staproehl opened 1 month ago

staproehl commented 1 month ago

Quick summary

Additional CSS option is unavailable in Site Editor and Customizer when an FSE theme in installed on a Starter Plan with a Custom CSS subscription.

Steps to reproduce

  1. Add Custom CSS subscription to Starter Plan
  2. Install FSE theme (original report came from Assembler, but was tested on Twenty Twenty Four as well)
  3. Go to Appearance menu item (See first result)
  4. Go to Editor -> Styles -> Sidebar Style panel -> More icon with three dots (See second result)

What you expected to happen

First result - Even though its an FSE theme, sometimes Customizer is available so the expected outcome isn't definitive and depends on if Customizer should be available with FSE themes. In these testings and the original user report, Additional CSS in Customizer was not available. However, HE SU'd into user's site and could access Customizer, which showed custom CSS added, even though the user reported not having access to it. These are screenshots of the SU with the assembler theme, where HE could see option for Additional CSS in Customizer but not Site Editor: Capture H0CysD0n Capture k61dcnsT

Second result - It is expected that the user has access to Additional CSS from the More icon in Site Editor, just as described in this guide: https://wordpress.com/support/editing-css/#access-the-css-editor-via-styles.

What actually happened

First result - Additional CSS is not present in Customizer.

Screen Shot 2024-06-20 at 8 26 25 PM Screen Shot 2024-06-20 at 8 30 32 PM

Second result - Additional CSS is not present in Site Editor.

Screen Shot 2024-06-20 at 8 25 11 PM Screen Shot 2024-06-20 at 8 31 41 PM

Impact

Some (< 50%)

Available workarounds?

Yes, and easy to implement. You can access Additional CSS via Customizer by going to Settings -> General -> Footer Credit -> Change Footer Credit

Platform (Simple and/or Atomic)

Simple

Logs or notes

The platform is still usable, but the subscription for Custom CSS is unusable.

Additional CSS via Customizer is available with a Classic theme.

Screen Shot 2024-06-20 at 8 34 45 PM
staproehl commented 1 month ago

User shared workaround of accessing Additional CSS via Customizer by going to General -> Settings -> Footer Credit -> Change Footer Credit. Confirmed it works!

okmttdhr commented 4 weeks ago

Thank you for raising an issue. This is because the Site Editor’s Additional CSS is part of Global Styles, and we gate Global Styles behind the Explorer plan. There is a proposal to address this issue in pdKhl6-3lt-p2. Please note that users can still navigate directly to /wp-admin/customize.php to use this feature (this is a workaround).


  1. Currently, Appearance > Additional CSS (Customizer's Additional CSS) menu is displayed (the reason I use the word "display" instead of "enable" is users can directly go to /wp-admin/customize.php) if Custom CSS is enabled AND one of the following conditions is met;
  1. On the other hand, the Site Editor’s Additional CSS is enabled if Custom CSS is enabled AND the user has the Explore plan or higher (<- This should be fixed).

  2. "Custom CSS is enabled" means it's enabled through Jetpack settings on Atomic, or the user is subscribed to the Custom CSS Add-On on Simple.

Please refer to the following documents for more details;