Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Jetpack Backup: Unable to restore the same backup twice in a row #92536

Open jp-imagines opened 3 months ago

jp-imagines commented 3 months ago

Quick summary

In some cases, you may need to restore a backup to undo changes after recently having restored the same backup. For example, if you restore a backup and then make changes to your site which you need to undo, restoring to the same backup would allow you to undo only those changes since the last restore point.

This is possible in the Calypso Activity Log. On the Jetpack > Backup page, however, you'll see a success message instead, preventing you from restoring the same backup again.

Steps to reproduce

  1. Start with an existing Atomic site.
  2. Restore a backup from Jetpack > Activity Log or Jetpack > Backup (Jetpack > VaultPress if using classic interface).
  3. Once the restoration finishes, optionally make some changes to your site.
  4. Navigate to Jetpack > Backup (Jetpack > VaultPress) and select the option to restore the same backup as in step 2.
  5. See a "Your site has been successfully restored." message instead of the option to restore.
  6. Navigate to Jetpack > Activity Log and find the same backup point as in step 2. Select the option to restore it.

What you expected to happen

The backup should be available to restore from Jetpack > Backup/VaultPress as it is at Jetpack > Activity Log.

What actually happened

Even after making changes post-restore, trying to restore the same backup from Jetpack > Backup/VaultPress shows a success message and prevents you from restoring it again.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Atomic

Logs or notes

Not yet tested on self-hosted. Replicated on a test site on both default interface and classic interface.

Initial report in 8445034-zd-a8c.

retnonindya commented 2 months ago

📌 REPRODUCTION RESULTS Replicated on my AT site

📌 FINDINGS/SCREENSHOTS/VIDEO Also, despite the success message:

Screenshot 2024-08-15 at 2 27 35 PM

... The restore never happened:

Screenshot 2024-08-15 at 2 28 33 PM

📌 ACTIONS Triaged

github-actions[bot] commented 2 months ago

Support References

This comment is automatically generated. Please do not edit it.