Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.4k stars 1.98k forks source link

Back button in help center not doing anything on click #93053

Closed lsl closed 1 month ago

lsl commented 1 month ago

Quick summary

Clicking on the back button doesn't do anything when opened directly into a support document. The mouse over effect looks possibly broken too.

https://github.com/user-attachments/assets/5387ccdb-fad3-43fe-a494-6c133264e469

Steps to reproduce

What you expected to happen

The help window to close

What actually happened

Nothing

Impact

One

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Atomic

Logs or notes

No response

mrfoxtalbot commented 1 month ago

I can replicate this. I suspect the button there is intended to take you back to the search results lists but it does not apply in this scenario because we are opening just one doc. Below is a video of how it should work:

https://github.com/user-attachments/assets/a7352e21-ea1a-4dc5-a169-7bd4a5b35eb6

The "Back" button should be hidden in this case.

escapemanuele commented 1 month ago

Hey 👋

https://github.com/user-attachments/assets/c69cd9eb-b071-4ea6-81ed-a95d8644c3ce

I'm in the editor and I'm able to go back. Maybe something we shipped in these 3 days fixed the navigation?

The glitch in the left arrow is still happening though

lsl commented 1 month ago

Looks fixed, thanks!