Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.41k stars 1.99k forks source link

Site Migration: JITM for users who try to import a playground/full-site zip file #93219

Open markbiek opened 2 months ago

markbiek commented 2 months ago

When a user tries to import a .zip file that contains plugins/themes/etc (eg from a WP playground or other full-site backup), we take them to the step to buy a Creator plan.

There is no warning which could be confusing/frustrating since we presented imports as being free. We should display a message when they upload a playground .zip.

This issue is to create/discuss a design for the new messaging and then implement that design.

P2 discussion: pfuQfP-yp-p2#comment-1032 Slack discussion: p1722606483011049-slack-C0Q664T29

markbiek commented 2 months ago

cc @fditrapani

github-actions[bot] commented 2 months ago

Support References

This comment is automatically generated. Please do not edit it.

fditrapani commented 2 months ago

Thanks @markbiek. I'll try work on a design next week!

fditrapani commented 2 months ago

I took some time to evaluate some options for this and here's how I think we should handle it:

After someone imports a playground or backup file, we show them a warning on the import screen that they need to upgrade:

image

Pressing upgrade would take them to checkout and then return them back to this screen to complete the import.

Upon further inspection, I noticed we can't actually import Playground files — even with a Creator/Business plan. Something seems to be broken there. If the scope of fixing that is too big a lift, an alternative approach could be to tell people to migrate their site instead:

image

From there, we ask for the upgrade and provide instructions for how to migrate.

Let me know what you think!

markbiek commented 2 months ago

I think the second option where we say "Playground files are not supported by our importer" is the way to go. I don't think the importer is designed to handle themes/plugins at all (which is why we have migrations instead).

fditrapani commented 2 months ago

Awesome! Let's go with that then. Let me know if you need anything from my end.

markbiek commented 2 months ago

Awesome! Let's go with that then. Let me know if you need anything from my end.

Will do! Thanks for jumping on that UI change!

fditrapani commented 2 months ago

We'll probably want to sync up some updates to our support docs because it's currently telling people they can import their Playground files which doesn't seem to be the case.

https://wordpress.com/support/import/

We should probably also remove the mention of the Playground zip under the import field. What do you think?

bohdankit07 commented 2 months ago

Let's look at the usage data first. If the numbers are low, it may be easier to turn it off completely until we find a fix and higher priorities are taken care of.

zaerl commented 2 months ago

I don't think the importer is designed to handle themes/plugins at al

Yes it does install everything possible. But the importers seems blocked now. A lot of changes have been made with migrations and co. so probably there is a bug somewhere.