search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.44k stars 1.99k forks source link

Help Center (module) CSS is loaded on site frontend on WordPress.com #93561

Closed sergiu-radu closed 3 months ago

sergiu-radu commented 3 months ago

Quick summary

Hello guys,

We recently noticed that the https://widgets.wp.com/help-center/help-center-wp-admin.css?ver=db43fb906617f7ff786e file is loaded on the front end of the site causing conflicts with the theme variables in the Blocksy theme.

I suspect this CSS is needed for this module: CleanShot 2024-08-15 at 19 05 18

The file rewrites some variables that are defined by the theme, specifically as you can see in the screenshot:

I understand that this is the naming convention you use in Calypso but at the same time it is not correct to apply them on the front end of the site.

Maybe you need to scope somehow those variables more specifically?

Steps to reproduce

  1. Start with a site that has a Business plan
  2. Install & activate Blocksy theme
  3. Install and activate the Blocksy Companion plugin
  4. Open "Customizer", make a small change and hit the "Publish" button
  5. Close the "Customizer" and open the frontend
  6. You will see that some parts with text are white

What you expected to happen

I expect the help-center-wp-admin.css won't override the theme colors.

What actually happened

All the text is white because help-center-wp-admin.css is overriding it.

Impact

All

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

sergiu-radu commented 3 months ago

Hello guys, do you have any updates on this?

arcangelini commented 3 months ago

Hey @sergiu-radu we have a few PR's that will address this issue that will get deployed ASAP. We are testing them now and should hopefully have them deployed in the next day or so.

sergiu-radu commented 3 months ago

Hi @arcangelini, that's awesome, thanks you very much for the heads up.

Have a wonderful day!

mxhassani commented 3 months ago

While waiting for the PR deploy, this is another report 8634538-zen

github-actions[bot] commented 3 months ago

Support References

This comment is automatically generated. Please do not edit it.

arcangelini commented 3 months ago

Just an update. We deployed a fix yesterday to Jetpack. This should get released today.

https://github.com/Automattic/jetpack/pull/38941

UPDATE: This has been deployed to WPCOM. We are waiting on another major bug fix before deploying to Atomic sites.

sergiu-radu commented 3 months ago

Hello @arcangelini, thanks for the heads up! I can confirm, this issue seems to be fixed on WPCOM, thank you!

arcangelini commented 3 months ago

The fix has landed ✅