search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.4k stars 1.98k forks source link

Domains page looking bad when user has no sites and one or more domains #93679

Open xavier-lc opened 1 month ago

xavier-lc commented 1 month ago

Quick summary

Accessing https://wordpress.com/domains/manage with a user that has no sites and one or more domains leaves you with a table that runs into the left side menu:

image

It might be related to https://github.com/Automattic/wp-calypso/pull/93017

Steps to reproduce

  1. Use a user that has no sites and one or more domains
  2. Go to https://wordpress.com/domains/manage

What you expected to happen

A good looking table:

image

What actually happened

A bad looking table:

image

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

If the above answer is "Yes...", outline the workaround.

Click on Sites, and then navigate back.

Platform (Simple and/or Atomic)

Simple

Logs or notes

No response

gius80 commented 1 month ago

It looks that the issue is not strictly related to domains with no sites (I was able to reproduce it with my user).

I suspect it could be a regression introduced with https://github.com/Automattic/wp-calypso/pull/93631

mrfoxtalbot commented 3 weeks ago

I recall seeing this on and off in passing a few times but could not replicate it.

@Addison-Stavlo, could you take a quick look at this to confirm if this is is indeed a regression coming from https://github.com/Automattic/wp-calypso/pull/93631 ?