hr HTML tags Breaking Paragraph Blocks and Classic Revisions Unless it's Inside

mxhassani commented 2 months ago

Quick summary

Adding an HTML code that code that contains the <hr> code results in an eventually broken block. Block recovery attempts recovers what's before the <hr> tag but not what's after it.

If using classic revisions (wp-admin). If a revision contains that <hr> tag, all the content will be visible in the revisions view but anything under the tag will not be included in the restored version.

Steps to reproduce

Using Gutenberg, on any post.
Add a paragraph block and write anything - "Test"
Edit the paragraph block as HTML and add an <hr> to the end, followed by some text.
Click Edit visually.
You will get an Attempt Block Recovery button
Clicking it removes the <hr> tag and all that's after it

There are

What you expected to happen

To either just remove the <hr> tag or convert it into a separator block.

What actually happened

The <hr> tag is removed and all that's after it, inside that paragraph block.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

If the above answer is "Yes...", outline the workaround.

Regarding the code.

Use the code editor to remove the HR tags manually

Regarding the revisions.

Make sure to use the Gutenberg revisions and not the classic revisions. The Gutenberg revisions do bring the content that's after the <hr> tag but the block remains "fragile".

Platform (Simple and/or Atomic)

Simple, Atomic, Self-hosted

Logs or notes

8631891-zen The user mentioned using Word and paste to Classic block when creating content.

github-actions[bot] commented 2 months ago

Support References

This comment is automatically generated. Please do not edit it.

[ ] 8631891-zen

retnonindya commented 2 months ago

@mxhassani - I'm afraid I can't see your report clearly here. This is what I see on my end:

It might be the text you shared got markdown-ed (? Is that even a word?) Can you reshare the message, Mohamed? Thanks!

mxhassani commented 2 months ago

@retnonindya Thanks! It was the hr tags at it again, I put them inside quotes.

inaikem commented 1 month ago

Moving this to the main triage queue since we received an author reply >month ago.

Robertght commented 3 weeks ago

📌 REPRODUCTION RESULTS

Tested on Simple – Replicated
Tested on Atomic – Replicated
Tested on P2 (optional) – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO https://github.com/user-attachments/assets/bd4e9f3a-9ebd-4b25-9c15-3e99496df49e

📌 ACTIONS

Triaged

📌 Message to Author @mxhassani I'm not sure if it's permitted to have

elements inside other ones, like paragraphs on Gutenberg, but I agree it could create mayhem for some users, especially with revisions. At the same time, I could not find another report so I've raised this as a bug on core: https://github.com/WordPress/gutenberg/issues/66467

cc @inaikem if you need to review this with someone from the Gutenberg team.

Robertght commented 2 weeks ago

@mxhassani I'm going to close this for now as we've heard from the core folks it's not planned thing, yet there's some room for improvement.

Ref: https://github.com/WordPress/gutenberg/issues/66467#issuecomment-2439953247

Please reopen if you find more cases like this.

Automattic / wp-calypso