Legacy Add Ons Merged With Premium Plan But Not Adding The Storage Space

[mxhassani]

Quick summary

When a site has a 10GB storage space and the user upgrades to Premium plan, the purchases are bundled, but neither the storage space isn't added to the site nor the "bundle" visible on the Purchases page, just the Premium plan. This is done automatically without consideration of the remaining time in the 10GB subscription or prompting the user.

Upgrading to the Personal or Business plans doesn't exhibit the same results (works fine).

Steps to reproduce

1. On a test account, free site.
2. Go to SA and add a 10GB subscription.
3. Check the media library, you will see 13GB or 11GB instead of 3GB/1GB.
4. Go to the account and upgrade to the Premium plan
5. Check the media library again, and note it's showing 13GB. You can doublecheck in BRC.

What you expected to happen

The 10GB subscription to remain and the storage to become 23GB. OR, to be prompted about the impact of the plan upgrade on the 10GB subscription.

What actually happened

The 10GB subscription is just removed. SA notes that as "Upgrade merged into new bundle purchase"

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

If the above answer is "Yes...", outline the workaround.

Add the 10GB subscription from SA. It seems immune to plan renewal but, if the user lets the Premium plan expire then repurchases it, the add-on will be removed again.

Platform (Simple and/or Atomic)

Simple

Logs or notes

This behavior seems to have been around for a few years now - p1601655692318700/1601654134.312000-slack-C03TY6J1A

8690305-zen

[github-actions[bot]]

Support References

This comment is automatically generated. Please do not edit it.

• [ ] 8690305-zen

[Robertght]

📌 REPRODUCTION RESULTS

• Tested on Simple – Replicated

📌 ACTIONS

• Triaged

[Robertght]

@Automattic/neutron if this can be looked into by your team.

[DavidRothstein]

I tested this starting with Free + 10 GB, and from a payments perspective that part is working correctly. The 10 GB add-on costs $20, the Premium plan costs $96, and during upgrade I was only charged the difference ($76). So the proration is working and the user is charged the correct amount. It is also communicated in checkout, although maybe not spectacularly:

Whether it should be canceled on upgrade or kept is more of a product team question (but I don't think we even actively sell the 10 GB add-on anymore so who knows). Overall, the behavior made sense to me though; since I had 13 GB before the upgrade, it is more sensible to assume I wanted 13 GB after rather than jumping to 23 GB.

But ah, now I see the problem... If you start off with 10 GB + Personal and then upgrade to Premium, that means you drop from 16 GB to 13 GB after upgrading, which isn't great. Also, surprisingly, the proration doesn't work correctly in this case. You get credit for the Personal plan during this upgrade, but not for the 10 GB add-on. That does seem like a bug.

Separately, in the first case, I noticed that if you cancel the Premium plan afterwards you don't get the full refund back (only the upgrade cost). This only happened for 10 GB; when I tested with an actively-sold add-on like Custom CSS, then I got the full refund after cancelling the Premium plan. We can maybe create a separate bug report for this.

[michaeldcain]

From planning:

Let's start by making sure that the 10gb add-on is included in the appropriate upgrade arrays (e.g. Bundle_Upsell) to see if that fixes some of these issues. If it's not a quick fix, we'll need to prioritize it against our current work. Leaving the low priority label, since it's likely a rare issue.