Closed escapemanuele closed 1 month ago
I conducted an investigation into the issue where the "Oferta" badge overlaps with the domain name.
The main cause of this overlap is a CSS rule that prevents domain titles (in this case, domain names) from breaking into multiple lines. This rule is intended to maintain readability, ensuring the full address appears on a single line, such as travis.a8c.testing+2024-signup-tester-stepper1@gmail.com, rather than splitting it into something like this:
rvis.a8c.testing+2024
-signup-tester-stepper1@gmail.com
However, this issue is more pronounced on mobile devices or smaller screens. I believe itβs crucial to consult designers on this matter. In my opinion, resolving this is essential.
Hey @renancarvalho ππ½
If we follow the same logic of the highlighted cards, the badge is stacked on top of a domain name when a domain name is too long. We could try something like this:
Alternatively, we could stack the label on top of the offer message. This is a bit inconsistent with the highlighted domains on top of the list, but to me it connects better the badge + message, all in the same place:
WDYT?
Hello @nuriapenya, this is sounds good to me. But the issue still there, specially on Mobile. The content gets expanded to accommodate the size of the domain name. In the screenshot below, there's a horizontal scroll.
Hello! Thank you for the input @nuriapenya I agree with your proposed solution but/and I think we should have a max width for domain names and turn them into 2 lines if the name is very long.
Hello @JanaMW27 π , I like this approach since, I think, this is a bit of an edge case. I've considered trimming/truncating, but I think this is more readable.
Shall we proceed with this approach?
Sounds good to me
@JanaMW27 and @nuriapenya , WDYT?
https://github.com/user-attachments/assets/b9420cbe-4ce6-4a5e-bed2-7352ef58a776
I think there is too much spacing in the price module. Can we put the price in line with the domain name?
Details
Reported in https://github.com/Automattic/wp-calypso/issues/94394
This happens in both /start and Stepper. To trigger the offer I found that it is helpful to add a paid domain to the cart
Checklist
No response
Related
No response