search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Left sidebar (admin-menu): match Calypso and wp-admin color schemes #94471

Open fushar opened 2 months ago

fushar commented 2 months ago

There seems to be discrepancies in certain admin color schemes between Calypso and wp-admin screens for the left sidebar.

Examples below are using Classic Bright:

Site card (for Default admin interface style)

Calypso wp-admin
image image

Differences:

  1. Site card borders: wp-admin's seems to have top and bottom borders.
  2. Site card background also have different colors in some color schemes.
  3. Coming soon badge background colors.
  4. Margins around the "Free domain" upsell banner.

Sidebar menus (both Default and Classic?)

Calypso wp-admin
image image

Cleaning up "navredesign" variables

Can we now remove the --color-navredesign-sidebar-menu-* variables introduced from the following PRs?

They are confusing. IMO, we should have the same set of color definitions for both Default and Classic styles, and they need to match wp-admin's definitions.

davemart-in commented 2 months ago

Do we need to address this across all color schemes?

fushar commented 2 months ago

Yes, we need to audit all color schemes. I see that some already match, and some don't.