Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Site Editor: Searching for a page causes page to go blank #95243

Closed rw-ye closed 2 weeks ago

rw-ye commented 3 weeks ago

Quick summary

When searching for a page in the "Pages" section of the site editor, it causes the entire page to go blank. I can consistently reproduce on both AT and Simple sites.

Video:

https://github.com/user-attachments/assets/e68d633d-1bde-43f9-9587-94d036dd39ac

Steps to reproduce

  1. Make sure you have a FSE theme active.
  2. Navigate to the site editor (Appearance > Editor)
  3. Select "Pages"
  4. Search for a page
  5. The entire page will go blank

What you expected to happen

To be able to search for a page

What actually happened

The entire page goes blank

Impact

Most (> 50%)

Available workarounds?

Yes, easy to implement

If the above answer is "Yes...", outline the workaround.

The workaround is to use the "Pages" section on the site dashboard instead.

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

No response

Robertght commented 3 weeks ago

📌 REPRODUCTION RESULTS

📌 FINDINGS/SCREENSHOTS/VIDEO

Image

📌 ACTIONS

Weirdly, another similar thing I found yesterday but more specific to mobile use: https://github.com/Automattic/wp-calypso/issues/95072

sejas commented 3 weeks ago

I can reproduce the issue on simple and atomic when searching

Image

I see the same error in console:

TypeError: Cannot read properties of undefined (reading 'id')
    at iS (index.min.js?m=1726663399i&ver=088cb1de53fe673a60d6:120:948)
    at index.min.js?m=1726663399i&ver=088cb1de53fe673a60d6:100:15607
    at index.min.js?m=1726663399i&ver=088cb1de53fe673a60d6:100:15902
    at index.min.js?m=1726663399i&ver=088cb1de53fe673a60d6:100:16007
    at Vr (VM45 react-dom.min.js:1:73191)
    at Cl (VM45 react-dom.min.js:1:92835)
    at dl (VM45 react-dom.min.js:1:85243)
    at Nn (VM45 react-dom.min.js:1:32432)
    at VM45 react-dom.min.js:1:91667
    at El (VM45 react-dom.min.js:1:91672)

I tested it on a non WPcom site and I see a similar behaviour in core. When searching a page the whole page turns "gray" and stays like that until the user clicks anywhere. The biggest difference is that WPcom throws an error in console and "crashes".

https://github.com/user-attachments/assets/19c9834c-0ff4-494c-a50e-c617a3030a32

sejas commented 3 weeks ago

I've tested a regular site (non WPcom) with Gutenberg 19.4.0 and I don't see the "blinking" anymore.

I've also tested a simple site using the sticker gutenberg-edge v19.4.0-rc1 and I confirm that version of Gutenberg fixes the issue. You can add the Sticker gutenberg-edge to try it.

It seems that Gutenberg had an issue that cleared the dom when searching and that produced a conflict with some of our custom code. I'll see if I can find where it conflicts in WPcom side.

donnapep commented 3 weeks ago

@sejas Our team is currently on the Gutenberg rotation. The plan is to release Gutenberg 19.4.0 next week, but @Imran92 can confirm. 🙂

obenland commented 3 weeks ago

@donnapep Can we accelerate shipping that update? Please feel free to pull in @Automattic/bespin and @Automattic/caribou folks as needed. A Blocker-level issue should be fixed as soon as we can.

Imran92 commented 3 weeks ago

Hi @obenland 👋

I've already released v19.4.0 on simple edge sites.

Posted a CFT here pdtkmj-321-p2 and cross-posted to Nexus, Bespin and Caribou for quick turnaround.

I'll try to release before Thursday EOD to avoid releasing on Friday if everything goes as expected.

Thanks!

cc: @donnapep

Imran92 commented 2 weeks ago

v19.4.0 is released on simple sites.

The release build for AT is also in the right repo. AT will pull it following their schedule [p9o2xV-3Ov-p2#comment-8716]

github-actions[bot] commented 2 weeks ago

Support References

This comment is automatically generated. Please do not edit it.

obenland commented 2 weeks ago

Thank you for getting it out before the weekend @Imran92!

donnapep commented 2 weeks ago

Retested on both Simple and Atomic and confirm that this has been fixed. 🥳