Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Remove the Editor Iframe #95393

Open Copons opened 3 days ago

Copons commented 3 days ago

Some useful resources:

fushar commented 2 days ago

Adding a comparison of some features (that will go away) in the iframed editor, vs Core:

Feature iframed editor Core
Media Library Image Image
Revisions Image Image
Copons commented 2 days ago

Good point @fushar! Those are actual blockers for this issue, and we need to wait for Core editor updates to fill the gaps.

@richtabor I think revisions and media library were briefly mentioned in the check-in. Do you have any specific details about them? Otherwise, we should discuss them at the next check-in.

richtabor commented 2 days ago

Of these here, can you list for each what we'd want to consider bringing to core?

What exactly are the changes for each that Calypso does better, and do customers rely on those changes today?

For example, I'm not sure if the Calypso revisions is much of a win over core.

Copons commented 2 days ago

I was under the impression that we were already working to bring some of those features to Core, but I must have misunderstood. So, a few things off the top of my head:

Revisions

I'd argue that neither Core nor Calypso does a particularly good job, especially with blocks and the visual clutter they bring in code view. However...

Calypso has:

Core has:

Media Library

Calypso has:

Core has:


I'd say there are no winners overall. I've highlighted the Calypso features that I consider good ones for Core. Possibly, external sources in the media library is the only dealbreaker, but otherwise, I don't see any blockers. 🤔