Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

A4A: Fix Pressable referrals UI issues. #96493

Closed jkguidaven closed 1 week ago

jkguidaven commented 1 week ago

This PR closes a couple of issues related to Pressable referrals.

Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1472 Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1486 Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1481 Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1474 Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1471

Proposed Changes

Issue Before After
1. Add a 'Managed in Pressable' link on the Client subscription page for the Pressable subscription. https://github.com/Automattic/automattic-for-agencies-dev/issues/1472 Screenshot 2024-11-18 at 9 31 33 PM Screenshot 2024-11-18 at 8 06 54 PM
2. Display the 'Pressable' badge rather than the assigned site for active Pressable licenses on the Referrals overview page. https://github.com/Automattic/automattic-for-agencies-dev/issues/1481 Screenshot 2024-11-18 at 9 35 21 PM Screenshot 2024-11-18 at 8 19 12 PM
3. Display a 'Referral' badge for client-owned licenses on the Licenses page. https://github.com/Automattic/automattic-for-agencies-dev/issues/1474 Screenshot 2024-11-18 at 9 37 14 PM Screenshot 2024-11-18 at 9 37 28 PM
4. Resolve calculation errors for commissions on products with a total cost of over $1k. https://github.com/Automattic/automattic-for-agencies-dev/issues/1486 Screenshot 2024-11-18 at 9 41 19 PM Screenshot 2024-11-18 at 9 39 53 PM
5. Hide Pressable usage for client-owned Pressable licenses. https://github.com/Automattic/automattic-for-agencies-dev/issues/1471 Screenshot 2024-11-18 at 10 02 16 PM Screenshot 2024-11-18 at 10 02 02 PM

Why are these changes being made?

Testing Instructions

For proper testing, it is essential to test the branch locally.

Issue 1

Issue 2

Issue 3

Issue 4

Issue 5

Pre-merge Checklist

github-actions[bot] commented 1 week ago
Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-124930
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-124930&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-124930&env=a8c-for-agencies
matticbot commented 1 week ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~565 bytes added 📈 [gzipped])

``` name parsed_size gzip_size a8c-for-agencies-client +651 B (+0.1%) +174 B (+0.0%) a8c-for-agencies-purchases +171 B (+0.0%) +353 B (+0.2%) a8c-for-agencies-referrals +105 B (+0.0%) +35 B (+0.0%) a8c-for-agencies-marketplace -65 B (-0.0%) +3 B (+0.0%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size? **Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

matticbot commented 1 week ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/a4a/pressable-referral-issues on your sandbox.

a8ci18n commented 1 week ago

Translation for this Pull Request has now been finished.