Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

A4A > Agency Tier: implement feature announcement modal #96498

Closed yashwin closed 1 week ago

yashwin commented 1 week ago

Proposed Changes

This PR implements a feature announcement modal for the Agency Tier.

Why are these changes being made?

Testing Instructions

Screenshot 2024-11-18 at 8 38 07 PM Screenshot 2024-11-18 at 8 38 22 PM

Pre-merge Checklist

github-actions[bot] commented 1 week ago
Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-124936
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-124936&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-124936&env=a8c-for-agencies
matticbot commented 1 week ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/a4a/agency-tier/announcement-modal on your sandbox.

matticbot commented 1 week ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~300 bytes added 📈 [gzipped])

``` name parsed_size gzip_size a8c-for-agencies-overview +1011 B (+0.1%) +310 B (+0.1%) a8c-for-agencies-purchases +90 B (+0.0%) -10 B (-0.0%) a8c-for-agencies-marketplace +90 B (+0.0%) -10 B (-0.0%) a8c-for-agencies-client +90 B (+0.0%) -10 B (-0.0%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size? **Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

a8ci18n commented 1 week ago

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17008025

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @yashwin for including a screenshot in the description! This is really helpful for our translators.

a8ci18n commented 1 day ago

Translation for this Pull Request has now been finished.