Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Fix "unavailable tld" message in Gravatar domain flow #96503

Closed gius80 closed 4 days ago

gius80 commented 4 days ago

Proposed Changes

We recently update the number of supported domain extensions in the domains Gravatar flow. This PR updates the message that we shows if the user search for an unsupported tld using a fqdn in the search field.

Depends on D166507-code

gravatar message

Why are these changes being made?

The message we are currently showing is wrong, since it's say that we are supporting only .link domains.

Testing Instructions

Apply this patch and the corresponding back one (D166507-code), the visit the Gravatar flow at /start/domain-for-gravatar/domain-only.

Pre-merge Checklist

github-actions[bot] commented 4 days ago
Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:commit-c1a8cdf711dd6a72badd33dba54816aa47f52075
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:commit-c1a8cdf711dd6a72badd33dba54816aa47f52075&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:commit-c1a8cdf711dd6a72badd33dba54816aa47f52075&env=a8c-for-agencies
matticbot commented 4 days ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~0 bytes added 📈 [gzipped])

``` name parsed_size gzip_size update-design-flow +49 B (+0.0%) +0 B link-in-bio-tld-flow +49 B (+0.0%) +0 B domains +49 B (+0.0%) +0 B copy-site-flow +49 B (+0.0%) +0 B ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~0 bytes added 📈 [gzipped])

``` name parsed_size gzip_size async-load-signup-steps-domains +49 B (+0.0%) +0 B ``` React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size? **Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

a8ci18n commented 4 days ago

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17008041

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @gius80 for including a screenshot in the description! This is really helpful for our translators.