Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Odie: Fix spacing and improve translations of disclaimers in user messages #96505

Open stephanethomas opened 1 week ago

stephanethomas commented 1 week ago

This pull request fixes the following minor display issues in the disclaimers shown at the bottom of a message generated by an AI bot (just before the Related Guides section), when requesting help from the Support Assistant:

Help center experience enabled

Before After
image image

Help center experience disabled

Before After
image image

This pull request also concatenates those strings together, an approach usually recommended as it provides more context to translators.

Testing instructions

  1. Run git checkout fix/odie-user-message-disclaimers and start your server, or access a live branch
  2. Click the question mark icon at the top of any page
  3. Click the Still need help? button at the bottom of the modal box
  4. Ask something, e.g. how to change header on one page only ?
  5. Assert that the disclaimer is shown correctly now:

    Generated by WordPress.com's Support AI. AI-generated responses may contain inaccurate information. Learn more ↗.

  6. Add ?flags=help-center-experience at the end of the url, and hit enter
  7. Repeat the same step, and assert that the disclaimer is shown correctly this time:

    Powered by Support AI. Some responses may be inaccurate. Learn more ↗.

github-actions[bot] commented 1 week ago
Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-124956
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-124956&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-124956&env=a8c-for-agencies
matticbot commented 1 week ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~8 bytes added 📈 [gzipped])

``` name parsed_size gzip_size async-load-automattic-help-center -15 B (-0.0%) +8 B (+0.0%) ``` React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size? **Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

matticbot commented 1 week ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/odie-user-message-disclaimers on your sandbox.

stephanethomas commented 5 days ago

In the spirit of moving forward, I'm going to merge this pull request, but I'm happy to update that code to add Tracks events in another one if that's needed.

stephanethomas commented 5 days ago

Actually, I'm going to wait until the strings have been translated.

a8ci18n commented 5 days ago

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17009735

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @stephanethomas for including a screenshot in the description! This is really helpful for our translators.

a8ci18n commented 23 hours ago

Translation for this Pull Request has now been finished.