Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Blaze location charts #96511

Closed j6ll closed 1 day ago

j6ll commented 4 days ago

Related to 2728-gh-org/a8c-dsp

Proposed Changes

New charts to give the user a breakdown of their impressions or clicks by Country

See an example at: /advertising/campaigns/{campaignId}/{domain}

https://github.com/user-attachments/assets/d6804a9b-7a09-4648-99f0-9a1c1c14ed2e

Testing Instructions

Default View Screenshot 2024-11-18 at 18 58 28

Expanded Screenshot 2024-11-18 at 18 58 23

Colour scheme Screenshot 2024-11-18 at 19 34 38

Locale translation Screenshot 2024-11-18 at 19 36 22

Pre-merge Checklist

github-actions[bot] commented 4 days ago
Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125174
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125174&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125174&env=a8c-for-agencies
matticbot commented 4 days ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

To test WordPress.com changes, run install-plugin.sh $pluginSlug jamesgill23/wp-blaze-location-charts on your sandbox.

matticbot commented 3 days ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~544 bytes added 📈 [gzipped])

``` name parsed_size gzip_size promote-post-i2 +2045 B (+0.3%) +544 B (+0.2%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size? **Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

a8ci18n commented 1 day ago

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17011206

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @j6ll for including a screenshot in the description! This is really helpful for our translators.