Plans: Make storage selection reflection in header price optional

jeyip commented 3 days ago

Proposed Changes

Disable storage add-on selection updates in header price for the calypso_plans_page_emphasize_longer_plan_savings experiment if enableTermSavingsPriceDisplay flag is enabled
Prop drill the enableTermSavingsPriceDisplay feature flag into pricing meta hook. If enabled, prevent storage add-on calculations in features grid + comparison grid header price.

Why are these changes being made?

See p1726619377025979/1724962428.022989-slack-C07ABDFQEMS

Testing Instructions

Go to /plans/:site?flags=plans/term-savings-price-display and /start/plans?flags=plans/term-savings-price-display
Ensure that when storage add-ons are selected for business or ecommerce annual plans, the header price doesn't change

Pre-merge Checklist

[ ] Has the general commit checklist been followed? (PCYsg-hS-p2)
[ ] Have you written new tests for your changes?
[ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
[ ] Have you checked for TypeScript, React or other console errors?
[ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
[ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
[ ] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

github-actions[bot] commented 3 days ago

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-124991

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-124991&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-124991&env=a8c-for-agencies

matticbot commented 3 days ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

notifications
odyssey-stats
wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/term-savings-pricing-to-ignore-storage-addon-selections on your sandbox.

matticbot commented 3 days ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~741 bytes added 📈 [gzipped])

``` name parsed_size gzip_size update-design-flow +2063 B (+0.2%) +518 B (+0.2%) plugins +2063 B (+0.1%) +520 B (+0.1%) plans +2063 B (+0.2%) +519 B (+0.1%) link-in-bio-tld-flow +2063 B (+0.1%) +511 B (+0.1%) jetpack-app +2063 B (+0.5%) +519 B (+0.4%) theme +36 B (+0.0%) +23 B (+0.0%) stats +36 B (+0.0%) +25 B (+0.0%) site-purchases +36 B (+0.0%) +25 B (+0.0%) purchases +36 B (+0.0%) +25 B (+0.0%) posts-custom +36 B (+0.0%) +26 B (+0.0%) posts +36 B (+0.0%) +26 B (+0.0%) migrate +36 B (+0.0%) +26 B (+0.0%) import-hosted-site-flow +36 B (+0.0%) +26 B (+0.0%) hosting +36 B (+0.0%) +26 B (+0.0%) domains +36 B (+0.0%) +25 B (+0.0%) checkout +36 B (+0.0%) +27 B (+0.0%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~545 bytes added 📈 [gzipped])

``` name parsed_size gzip_size async-load-signup-steps-plans-theme-preselected +2063 B (+0.5%) +519 B (+0.4%) async-load-signup-steps-plans +2063 B (+0.5%) +519 B (+0.4%) async-load-design-blocks +36 B (+0.0%) +26 B (+0.0%) ``` React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

**Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

jeyip commented 1 day ago

Hey @chriskmnds just leaving a message here to say I didn't miss your comments. Will get to them tomorrow 😎

jeyip commented 13 hours ago

It's getting near the end of my day. I started reviewing the comment, but will continue tomorrow. Thanks for the patience!

Automattic / wp-calypso