Closed yashwin closed 2 days ago
https://calypso.live?image=registry.a8c.com/calypso/app:build-125043&env=jetpack |
https://calypso.live?image=registry.a8c.com/calypso/app:build-125043&env=a8c-for-agencies |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:
Sections (~1398 bytes added 📈 [gzipped])
Legend
Generated by performance advisor bot at iscalypsofastyet.com.
About my previous comment about the
Go to Markertplace
button, the same happens with theTag your site
andAdd my bank information
.Other than that, it will LGTM!
Thanks for the review, @cleacos!c
Good catch.I missed committing some changes. It is fixed now: https://github.com/Automattic/wp-calypso/pull/96525/commits/d47db9841b3c74becda4dbdbe56f9e394a8c0740
Could you please take another look?
This PR modifies the release build for the following Calypso Apps:
For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run install-plugin.sh $pluginSlug add/self-migration-tool-steps
on your sandbox.
Looking good @yashwin, I'll add notes as I go:
Can we add 16px top padding to a4a-layout__body-wrapper
. So that we get the usual 32px top padding.
Can we change the left padding on foldable-card__content
to 72px so that it's aligned with the title?
Would also be a bit nicer to set the top padding on that one to 0:
For mobile, I'd recommend we stick to consistent button layout, stacked looks good to me: Also if we could bump the title down one size on mobile that would help.
Thanks for the review, @madebynoam!
I have made all the changes you have suggested!
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17009383
Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.
Thank you @yashwin for including a screenshot in the description! This is really helpful for our translators.
Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1488
Proposed Changes
This PR:
Why are these changes being made?
Testing Instructions
1) Open the A4A live link. 2) Go to the /migrations/overview page > Click the
Migrate your site
dropdown button 3) Select theSelf migrate to WordPress.com
option > Verify that the steps are matching as per the design(link in the issue). Also, verify that the cards fold when they are marked as done and opens when reset. Clicking on the contact us button on the page heading should open the contact us modal with the appropriate product selected. 4) Repeat step 2 > Verify the same forSelf migrate to Pressabel
option.@madebynoam: Please check if the mobile view ok.
Mixed state:
Pre-merge Checklist