Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Performance Monitoring feature says a site needs to be launched despite it being public already #96533

Closed mrfoxtalbot closed 19 hours ago

mrfoxtalbot commented 3 days ago

Quick summary

I have noticed some scenarios where the performance test tool (wordpress.com/sites/performance) asks users to "Launch" their site to test its performance, despite the site being live already.

This seems to happen in two scenarios:

  1. The sites uses A records to connect the domain
  2. The site uses Cloudflare

I suspect hat the tool is testing the site's DNS and classifying it as "private" unless the DNS point to WordPress.com's DNS

Steps to reproduce

  1. Set up a site whose domain is connected via A records (or that's using Cloudflare)
  2. Make sure the site has been launched and is public
  3. Navigate to https://wordpress.com/sites/performance/
  4. Notice how performance tests are unavailable and you are directed to launch the site:

Performance statistics are only available for public sites. Launch your site to start measuring performance

Image

Site: https://losporfiados.com (A records) Site: https://efe.com (Cloudflare)

What you expected to happen

Performance tests should work with all domain setups, DNS, A records, or Cloudflare.

What actually happened

They did not work in some scenarios, see above.

Impact

All

Available workarounds?

Yes, difficult to implement

If the above answer is "Yes...", outline the workaround.

Users can still use the public testing tool at https://wordpress.com/speed-test and even subscribe to results but the current response is confusing and nowhere as convenient.

Platform (Simple and/or Atomic)

Atomic

Logs or notes

No response

github-actions[bot] commented 3 days ago

OpenAI suggested the following labels for this issue:

gavande1 commented 3 days ago

@vykes-mac, Could you or someone from the quake team take a look at it?

vykes-mac commented 2 days ago

@mrfoxtalbot Can you test your site again using the Calypso live link from the PR https://container-beautiful-gould.calypso.live/sites

mrfoxtalbot commented 3 hours ago

Fixed!

Image

Thank you for working on this @vykes-mac!!