Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Help Center: Do not call Support Interaction APIs in old version #96540

Closed escapemanuele closed 1 day ago

escapemanuele commented 3 days ago

Related to #

Proposed Changes

Avoid calling the Support Interaction APIs in the old version, since we're not using them there.

Testing Instructions

matticbot commented 3 days ago
Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125178
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125178&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125178&env=a8c-for-agencies
matticbot commented 3 days ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

To test WordPress.com changes, run install-plugin.sh $pluginSlug help-center-avoid-calling-support-interaction on your sandbox.

matticbot commented 3 days ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~8 bytes added 📈 [gzipped])

``` name parsed_size gzip_size async-load-automattic-help-center +38 B (+0.0%) +8 B (+0.0%) ``` React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size? **Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

renancarvalho commented 3 days ago

Left a small suggestion, played a bit with and without the flag and did not see any request going through without the flag. Seems to be working great 👍