Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Untangling: apply new design to Settings -> Administration -> Delete site #96544

Closed fushar closed 5 days ago

fushar commented 6 days ago

Fixes https://github.com/Automattic/dotcom-forge/issues/9862

Proposed Changes

This PR applies the new global view design to Settings -> Administration -> Delete site flow.

Why are these changes being made?

pbxlJb-6ye-p2

Testing Instructions

  1. Open /sites.
  2. Click a site.
  3. Go to Settings -> Administration.
  4. Click the Delete your site permanently button.
  5. Verify you see this:
image
  1. Submit the form, verify the site is deleted.
  2. REGRESSION: Transfer another site via /settings/general/:slug; verify the flow can still be completed.

Pre-merge Checklist

github-actions[bot] commented 6 days ago
Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125127
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125127&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125127&env=a8c-for-agencies
matticbot commented 6 days ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

To test WordPress.com changes, run install-plugin.sh $pluginSlug untangling/delete-site on your sandbox.

matticbot commented 6 days ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~111 bytes removed 📉 [gzipped])

``` name parsed_size gzip_size site-settings -111 B (-0.0%) -77 B (-0.0%) settings -92 B (-0.0%) -113 B (-0.0%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size? **Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

a8ci18n commented 5 days ago

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17009400

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @fushar for including a screenshot in the description! This is really helpful for our translators.

a8ci18n commented 1 day ago

Translation for this Pull Request has now been finished.