Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Domains: Limit TLDs of domain suggestions in the 100-year plan flow #96555

Closed leonardost closed 2 hours ago

leonardost commented 2 days ago

Proposed Changes

This PR limits the TLDs of domains that are suggested in the 100-year plan flow to com, net, org and blog.

Before After
Screenshot 2024-11-19 at 16 33 14 Screenshot 2024-11-19 at 16 33 03

Why are these changes being made?

Standardization with the 100-year domain flow: these 4 TLDs are the same as the ones offered in that flow.

Testing Instructions

Pre-merge Checklist

github-actions[bot] commented 2 days ago
Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125082
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125082&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125082&env=a8c-for-agencies
matticbot commented 2 days ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/limit-domain-suggestion-tlds-of-100-year-plan-flow on your sandbox.

matticbot commented 2 days ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~23 bytes added πŸ“ˆ [gzipped])

``` name parsed_size gzip_size entry-stepper +39 B (+0.0%) +23 B (+0.0%) ``` Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~152 bytes added πŸ“ˆ [gzipped])

``` name parsed_size gzip_size marketplace +61 B (+0.0%) +18 B (+0.0%) domains +61 B (+0.0%) +19 B (+0.0%) themes +39 B (+0.0%) +11 B (+0.0%) theme +39 B (+0.0%) +11 B (+0.0%) staging-site +39 B (+0.0%) +11 B (+0.0%) sites-dashboard +39 B (+0.0%) +11 B (+0.0%) site-tools +39 B (+0.0%) +11 B (+0.0%) site-settings +39 B (+0.0%) +11 B (+0.0%) site-purchases +39 B (+0.0%) +11 B (+0.0%) site-performance +39 B (+0.0%) +11 B (+0.0%) site-monitoring +39 B (+0.0%) +11 B (+0.0%) site-marketing +39 B (+0.0%) +11 B (+0.0%) site-logs +39 B (+0.0%) +11 B (+0.0%) site-blocks +39 B (+0.0%) +11 B (+0.0%) signup +39 B (+0.0%) +11 B (+0.0%) settings +39 B (+0.0%) +15 B (+0.0%) security +39 B (+0.0%) +11 B (+0.0%) purchases +39 B (+0.0%) +11 B (+0.0%) privacy +39 B (+0.0%) +11 B (+0.0%) plugins +39 B (+0.0%) +11 B (+0.0%) plans +39 B (+0.0%) +11 B (+0.0%) notification-settings +39 B (+0.0%) +11 B (+0.0%) me +39 B (+0.0%) +11 B (+0.0%) jetpack-connect +39 B (+0.0%) +11 B (+0.0%) jetpack-cloud-settings +39 B (+0.0%) +11 B (+0.0%) jetpack-cloud-pricing +39 B (+0.0%) +11 B (+0.0%) jetpack-cloud-features-comparison +39 B (+0.0%) +11 B (+0.0%) jetpack-app +39 B (+0.0%) +12 B (+0.0%) hosting-features +39 B (+0.0%) +11 B (+0.0%) hosting +39 B (+0.0%) +11 B (+0.0%) home +39 B (+0.0%) +11 B (+0.0%) help +39 B (+0.0%) +11 B (+0.0%) github-deployments +39 B (+0.0%) +11 B (+0.0%) email +39 B (+0.0%) +11 B (+0.0%) developer +39 B (+0.0%) +11 B (+0.0%) checkout +39 B (+0.0%) +11 B (+0.0%) account-close +39 B (+0.0%) +11 B (+0.0%) account +39 B (+0.0%) +11 B (+0.0%) update-design-flow +22 B (+0.0%) +8 B (+0.0%) link-in-bio-tld-flow +22 B (+0.0%) +8 B (+0.0%) copy-site-flow +22 B (+0.0%) +8 B (+0.0%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~81 bytes added πŸ“ˆ [gzipped])

``` name parsed_size gzip_size async-load-design-blocks +61 B (+0.0%) +18 B (+0.0%) async-load-purchase-modal-wrapper +39 B (+0.0%) +11 B (+0.0%) async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou... +39 B (+0.0%) +11 B (+0.0%) async-load-calypso-my-sites-current-site-stale-cart-items-notice +39 B (+0.2%) +10 B (+0.1%) async-load-calypso-layout-masterbar-checkout +39 B (+0.1%) +11 B (+0.0%) async-load-calypso-blocks-editor-checkout-modal +39 B (+0.0%) +12 B (+0.0%) async-load-signup-steps-domains +22 B (+0.0%) +8 B (+0.0%) ``` React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size? **Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.