Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Preload setup page on the authorize page #96558

Closed moon0326 closed 18 hours ago

moon0326 commented 2 days ago

Related to #96420

Proposed Changes

Testing Instructions

  1. Checkout this branch locally and run yarn start
  2. Make sure you're logged-in on WPCOM.
  3. Visit this link
  4. Click on Connect to WordPress.com and pay attention to the text.
  5. Make sure text and the image load at the same time.

Pre-merge Checklist

github-actions[bot] commented 2 days ago
Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125225
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125225&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125225&env=a8c-for-agencies
matticbot commented 2 days ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~5287 bytes added 📈 [gzipped])

``` name parsed_size gzip_size jetpack-connect +11688 B (+1.0%) +5287 B (+1.6%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size? **Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

matticbot commented 1 day ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/96420-janky-transition-to-the-loader-on-jpc on your sandbox.