Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Domains: Update the purchase settings page for 100-year domains #96560

Open leonardost opened 2 days ago

leonardost commented 2 days ago

Proposed Changes

This PR updates the purchase settings page for 100-year domains. These are the updates that were done:

Before After
Screenshot 2024-11-19 at 18 56 33 Screenshot 2024-11-19 at 18 56 19

Why are these changes being made?

This is part of the 100-year domains: UX updates project (pcYYhz-2q8-p2) to update Calypso for 100-year domains.

Testing Instructions

Pre-merge Checklist

github-actions[bot] commented 2 days ago
Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125199
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125199&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125199&env=a8c-for-agencies
matticbot commented 2 days ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~4003 bytes added 📈 [gzipped])

``` name parsed_size gzip_size site-purchases +6976 B (+0.4%) +3979 B (+0.9%) purchases +6976 B (+0.3%) +3979 B (+0.7%) update-design-flow +378 B (+0.0%) +24 B (+0.0%) link-in-bio-tld-flow +378 B (+0.0%) +24 B (+0.0%) copy-site-flow +378 B (+0.1%) +24 B (+0.0%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size? **Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

matticbot commented 1 day ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/purchase-settings-page-for-100-year-domains on your sandbox.

gius80 commented 22 hours ago

Tested and works as expected! There are some tests to fix, other than that, I think it's ok to ship it. I'm wondering if we should disable the credit card expiration message or just disable the autorenewal, but that's for another discussion