Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Remove DataViews pagination css overrides #96569

Closed lsl closed 3 hours ago

lsl commented 2 days ago

Fixes https://github.com/Automattic/dotcom-forge/issues/9691

Proposed Changes

Remove DataViews pagination css overrides

Before

before-pagination

After

after-pagination

Testing:

matticbot commented 2 days ago
Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125385
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125385&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125385&env=a8c-for-agencies
matticbot commented 2 days ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~28 bytes removed 📉 [gzipped])

``` name parsed_size gzip_size staging-site -92 B (-0.0%) -28 B (-0.0%) sites-dashboard -92 B (-0.0%) -28 B (-0.0%) site-tools -92 B (-0.0%) -28 B (-0.0%) site-settings -92 B (-0.0%) -28 B (-0.0%) site-performance -92 B (-0.0%) -28 B (-0.0%) site-monitoring -92 B (-0.0%) -28 B (-0.0%) site-marketing -92 B (-0.0%) -28 B (-0.0%) site-logs -92 B (-0.0%) -28 B (-0.0%) hosting-features -92 B (-0.0%) -28 B (-0.0%) hosting -92 B (-0.0%) -28 B (-0.0%) github-deployments -92 B (-0.0%) -28 B (-0.0%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size? **Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

okmttdhr commented 1 day ago

It seems we weren’t able to remove the overrides in https://github.com/Automattic/wp-calypso/blob/a8bc0a527b49fa7ba2f23a2aad80b64ac9c9ba74/client/sites/components/dotcom-style.scss#L408-L435, correct? If that’s the case, could we consider moving these overrides into sites-dataviews/dataview-style.scss? It would be helpful to include an explanation of why they can’t be removed at this time and when we might be able to address them.

okmttdhr commented 3 hours ago

I'm merging this PR after resolving the conflict!

matticbot commented 3 hours ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/pagination-override on your sandbox.