Closed lsl closed 3 hours ago
https://calypso.live?image=registry.a8c.com/calypso/app:build-125385&env=jetpack |
https://calypso.live?image=registry.a8c.com/calypso/app:build-125385&env=a8c-for-agencies |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:
Sections (~28 bytes removed 📉 [gzipped])
Legend
Generated by performance advisor bot at iscalypsofastyet.com.
It seems we weren’t able to remove the overrides in https://github.com/Automattic/wp-calypso/blob/a8bc0a527b49fa7ba2f23a2aad80b64ac9c9ba74/client/sites/components/dotcom-style.scss#L408-L435, correct?
If that’s the case, could we consider moving these overrides into sites-dataviews/dataview-style.scss
? It would be helpful to include an explanation of why they can’t be removed at this time and when we might be able to address them.
I'm merging this PR after resolving the conflict!
This PR modifies the release build for the following Calypso Apps:
For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run install-plugin.sh $pluginSlug update/pagination-override
on your sandbox.
Fixes https://github.com/Automattic/dotcom-forge/issues/9691
Proposed Changes
Remove DataViews pagination css overrides
Before
After
Testing: