Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Marketing -> Connections: move inline forms to modal #96573

Open fushar opened 2 days ago

fushar commented 2 days ago

Context: p9Jlb4-f3i-p2

Currently, some services like Bluesky and Mastodon have the connections form inline in the expandable section. This is inconsistent with other services, as we want to remove the empty states.

Let's move such forms into modal, as shown below:

Before After
Image Image

Figma for reference: WHjPtm5mPBnJyiBYVHHnDT-fi-655_238202

github-actions[bot] commented 2 days ago

OpenAI suggested the following labels for this issue:

matt-west commented 1 day ago

Let’s hold on this for now. Jetpack recently moved the connection UI to a modal. We can’t really open a modal inside a modal, so we need to find a better solution or drop this change entirely.

Image

cc @keoshi

fushar commented 1 day ago

@matt-west Sure thing! Thanks.