Stats: Change support links to open in a new tab

[jwebbdev]

Related to https://github.com/Automattic/red-team/issues/199

Proposed Changes

• Updating external jetpack.com and wordpress.com support links to open in a new tab

Why are these changes being made?

• This is a problem because interrupts the ongoing experience and, in some cases, the support link doesn’t allow users to go back using the browser “Back” action.

Testing Instructions

• verify that the inline support links open in a new tab

Pre-merge Checklist

• [ ] Has the general commit checklist been followed? (PCYsg-hS-p2)
• [ ] Have you written new tests for your changes?
• [ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• [ ] Have you checked for TypeScript, React or other console errors?
• [ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• [ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• [ ] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions[bot]]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125296

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125296&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125296&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stats-external-support-links on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~8 bytes added 📈 [gzipped])

``` name parsed_size gzip_size stats +1122 B (+0.1%) +8 B (+0.0%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~36 bytes added 📈 [gzipped])

``` name parsed_size gzip_size async-load-calypso-my-sites-stats-pages-insights +132 B (+0.2%) +30 B (+0.2%) async-load-calypso-my-sites-stats-pages-subscribers +33 B (+0.0%) +6 B (+0.0%) ``` React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

**Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[kangzj]

It looks good to me. I just wonder why the builds are failing for e2e tests🤔 I restarted them multiple times but no use.

[jwebbdev]

@kangzj I hadn't run the install-plugin.sh $pluginSlug update/stats-external-support-links items referenced. Not sure if that was the issue (though it seems it just pulls that from TC, not push... so still unclear) as after doing that and rerunning the failed TeamCity jobs they still failed. So I merged trunk and pushed to trigger another full workflow and it seemed to work.

[kangzj]

nah you don’t need to run that command. The command is for Odyssey Stats testing.

Thanks for fixing these! Very much appreciated! 🙇