Untangling: apply new design to Settings -> Administration -> Manage connection

fushar commented 2 days ago

Fixes https://github.com/Automattic/dotcom-forge/issues/9864

Proposed Changes

This PR applies the new global view design to Settings -> Administration -> Manage connection flow.

Why are these changes being made?

pbxlJb-6ye-p2

Testing Instructions

Prepare a fresh Jurassic Ninja site.
Connect it with Jetpack.
Go to DIRECT LINK (for now) /sites/settings/administration/:siteSlug
Click the Manage connection card, verify you see:

Try clicking around.
REGRESSION: Test also /settings/general/:siteSlug and click Manage connection at the bottom.

NOTE

I am not touching this Disconnect Jetpack flow because it's already "full-screen" and not that important in terms of Untangling Hosting Menu.

Pre-merge Checklist

[x] Has the general commit checklist been followed? (PCYsg-hS-p2)
[x] Have you written new tests for your changes?
[x] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
[x] Have you checked for TypeScript, React or other console errors?
[x] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
[x] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
[x] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

github-actions[bot] commented 2 days ago

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125230

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125230&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125230&env=a8c-for-agencies

matticbot commented 2 days ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

help-center
notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug untangling/manage-connection on your sandbox.

matticbot commented 2 days ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~90 bytes removed 📉 [gzipped])

``` name parsed_size gzip_size site-settings -883 B (-0.1%) -440 B (-0.1%) jetpack-cloud-settings +601 B (+0.1%) +154 B (+0.1%) settings -594 B (-0.1%) -376 B (-0.1%) plugins +315 B (+0.0%) +82 B (+0.0%) jetpack-cloud-plugin-management +315 B (+0.0%) +82 B (+0.0%) theme +190 B (+0.0%) +52 B (+0.0%) marketplace +190 B (+0.0%) +43 B (+0.0%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~43 bytes added 📈 [gzipped])

``` name parsed_size gzip_size async-load-design-playground +190 B (+0.0%) +43 B (+0.0%) async-load-design +190 B (+0.0%) +43 B (+0.0%) ``` React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

**Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

fushar commented 1 day ago

There are some problematic links in the disconnect flow.

Thanks, I decided to fix them all in this PR, including /stats => /sites.

Automattic / wp-calypso