Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Help Center: Switch to check if elapsed time less than 15 minutes #96579

Closed escapemanuele closed 1 day ago

escapemanuele commented 1 day ago

Related to p1732093892596739/1732093791.902089-slack-C07D72S1135

Proposed Changes

Instead of tracking the elapsed time, we just track if the answer from the user happened in less than 15 minutes.

Why are these changes being made?

ExPlat p1732054589211009/1732020069.327289-slack-CNTD4G117 doesn't support the <= operator for the elapsed_time property. We’ll need to incorporate that logic directly into the event. After analyzing historical data we agreed that 15 minutes (900 seconds) would be the most suitable threshold.

Testing Instructions

github-actions[bot] commented 1 day ago
Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125144
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125144&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125144&env=a8c-for-agencies
matticbot commented 1 day ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

To test WordPress.com changes, run install-plugin.sh $pluginSlug hc-update-tracking on your sandbox.

matticbot commented 1 day ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~14 bytes added 📈 [gzipped])

``` name parsed_size gzip_size async-load-automattic-help-center +19 B (+0.0%) +14 B (+0.0%) ``` React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size? **Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.