Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Rename sites/marketing/sharing route to /sharing-buttons #96581

Closed madhusudhand closed 1 day ago

madhusudhand commented 1 day ago

Fixes: https://github.com/Automattic/dotcom-forge/issues/9868

Proposed Changes

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

github-actions[bot] commented 1 day ago
Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125153
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125153&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125153&env=a8c-for-agencies
matticbot commented 1 day ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/rename-marketing-sharing-route on your sandbox.

matticbot commented 1 day ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~3 bytes added 📈 [gzipped])

``` name parsed_size gzip_size site-marketing +32 B (+0.0%) +3 B (+0.0%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size? **Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

fushar commented 1 day ago

Going to merge and deploy this 👍

taipeicoder commented 1 day ago

@madhusudhand can we add this to the CtD board? See p1732068120998669-slack-CRWCHQGUB.