Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Fix error when clicking on link #96582

Closed heavyweight closed 1 day ago

heavyweight commented 1 day ago

Fixes https://github.com/Automattic/dotcom-forge/issues/9032

Sentry errors brought to our attention that navigation can break when clicking on a link via the help center.

https://github.com/user-attachments/assets/86076287-11e3-4293-9aeb-507ed525b62b

Proposed Changes

Why are these changes being made?

Testing Instructions

github-actions[bot] commented 1 day ago
Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125154
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125154&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125154&env=a8c-for-agencies
matticbot commented 1 day ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/hc-article-link-error on your sandbox.

matticbot commented 1 day ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~10 bytes added 📈 [gzipped])

``` name parsed_size gzip_size async-load-automattic-help-center +27 B (+0.0%) +10 B (+0.0%) ``` React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size? **Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.