Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Untangling: apply new design to Marketing -> {Traffic, Sharing} #96586

Closed fushar closed 1 day ago

fushar commented 1 day ago

Fixes https://github.com/Automattic/dotcom-forge/issues/9858 Fixes https://github.com/Automattic/dotcom-forge/issues/9859

Proposed Changes

This PR applies the new global view design (almost) to Marketing -> {Traffic, Sharing}.

Traffic

Before After
image image

NOTE!!

I didn't touch this "component". Will do it when updating the Connections subtab, because it's a shared component.

image

Sharing

Almost no visible visual changes except border radius...

Why are these changes being made?

pbxlJb-6ye-p2

Testing Instructions

  1. Go to /sites
  2. Select a Simple site
  3. Go to Marketing -> Traffic and Marketing -> Sharing, try to break them
  4. Select an Atomic Default site
  5. Go to Marketing -> Traffic and Marketing -> Sharing, try to break them
  6. Select an Atomic Classic site
  7. Go to Marketing -> Traffic and Marketing -> Sharing, verify that only the Jetpack links are shown

Pre-merge Checklist

github-actions[bot] commented 1 day ago
Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125226
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125226&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125226&env=a8c-for-agencies
matticbot commented 1 day ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

To test WordPress.com changes, run install-plugin.sh $pluginSlug untangling/marketing-sharing-design on your sandbox.

matticbot commented 1 day ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~59 bytes removed πŸ“‰ [gzipped])

``` name parsed_size gzip_size entry-subscriptions +231 B (+0.0%) +57 B (+0.0%) entry-login +231 B (+0.0%) +57 B (+0.0%) entry-domains-landing +231 B (+0.0%) +57 B (+0.0%) entry-browsehappy +231 B (+0.1%) +57 B (+0.1%) entry-stepper -93 B (-0.0%) -59 B (-0.0%) entry-main -93 B (-0.0%) -59 B (-0.0%) ``` Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~3245 bytes removed πŸ“‰ [gzipped])

``` name parsed_size gzip_size site-marketing +517 B (+0.0%) +322 B (+0.1%) marketing +353 B (+0.1%) +239 B (+0.1%) staging-site -196 B (-0.0%) -676 B (-0.2%) site-settings -196 B (-0.0%) -651 B (-0.1%) hosting -196 B (-0.0%) -676 B (-0.1%) people +93 B (+0.0%) +1368 B (+0.7%) settings +65 B (+0.0%) +284 B (+0.1%) stats -13 B (-0.0%) -2 B (-0.0%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~93 bytes added πŸ“ˆ [gzipped])

``` name parsed_size gzip_size async-load-calypso-my-sites-site-settings-seo-settings-form +243 B (+0.1%) +93 B (+0.1%) ``` React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size? **Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

fushar commented 1 day ago

The "Search Engine Optimization" is not vertically centered, seems to have an extra bottom margin.

Thanks, fixed with a dirty way πŸ™ˆ