Help Center: Use correct colors for redesigned help center - Githubissues

Automattic / wp-calypso

The JavaScript and API powered WordPress.com

https://developer.wordpress.com

GNU General Public License v2.0

12.43k stars 1.99k forks source link

Help Center: Use correct colors for redesigned help center #96587

Open renancarvalho opened 1 day ago

renancarvalho commented 1 day ago

Related to https://github.com/Automattic/dotcom-forge/issues/9763 Fixes https://github.com/Automattic/dotcom-forge/issues/9763

Proposed Changes

Use Help Center redesigned colors instead themes color

Before:

After:

Why are these changes being made?

Keep Help Center style persistent.

Testing Instructions

Use live link and add the flag ?flags=help-center-experience
Change your sites theme.
Check the Help Center buttons, hover and focus, they should be the same in all themes
Check issue for more reference https://github.com/Automattic/dotcom-forge/issues/9763

Pre-merge Checklist

[ ] Has the general commit checklist been followed? (PCYsg-hS-p2)
[ ] Have you written new tests for your changes?
[ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
[ ] Have you checked for TypeScript, React or other console errors?
[ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
[ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
[ ] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

github-actions[bot] commented 1 day ago

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125410

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125410&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-125410&env=a8c-for-agencies

matticbot commented 1 day ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

help-center
notifications
wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/help_center_colors on your sandbox.

matticbot commented 1 day ago

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

heavyweight commented 21 hours ago

The focus style seems off for me:

Screenshot 2024-11-21 at 13 29 29

Screenshot 2024-11-21 at 13 28 58

renancarvalho commented 1 hour ago

~~@heavyweight did you yarn sync?~~ nvm pushed the fix :)