Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Make DataViews footer and plugin Management header sticky #96592

Closed paulopmt1 closed 10 hours ago

paulopmt1 commented 1 day ago

Related to https://github.com/Automattic/dotcom-forge/issues/9826 Project related: pet6gk-1CP-p2. Slack topic: p1732127914268039-slack-C04H4NY6STW

Proposed Changes

image

For Jetpack Cloud as well:

image

Testing Instructions

Pre-merge Checklist

matticbot commented 1 day ago
Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125342
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125342&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-125342&env=a8c-for-agencies
matticbot commented 1 day ago

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1 bytes removed 📉 [gzipped])

``` name parsed_size gzip_size plugins +11 B (+0.0%) -1 B (-0.0%) jetpack-cloud-plugin-management +11 B (+0.0%) -1 B (-0.0%) ``` Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size? **Parsed Size:** Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. **Gzip Size:** Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

matticbot commented 1 day ago

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/fix-dataviews-footer on your sandbox.

vykes-mac commented 1 day ago

I feel like there's an overlap with these 2 PRs https://github.com/Automattic/wp-calypso/pull/96576 and https://github.com/Automattic/wp-calypso/pull/96437. @p-jackson

vykes-mac commented 14 hours ago

Looks good. On larger screens the table rows looks a little weird hanging in white space because of the strong border color.

image

can we make the row borders same color as the one on the sites table? Its more subtle and blends better with the white background

image

since it's a css change maybe it can be done in this PR?